[webkit-reviews] review granted: [Bug 199337] unable to build WebRTC for iOS Simulator : [Attachment 373154] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 28 15:29:25 PDT 2019

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 199337: unable to build WebRTC for iOS Simulator

Attachment 373154: Patch


--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 373154
  --> https://bugs.webkit.org/attachment.cgi?id=373154

View in context: https://bugs.webkit.org/attachment.cgi?id=373154&action=review

> Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384
> +			script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm
-fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I
${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I
${SRCROOT}/Source/third_party/libvpx/source/libvpx -o

This is /such a hack/ and needs a comment and a bug tracking properly building
this for the host.

More information about the webkit-reviews mailing list