[webkit-reviews] review granted: [Bug 199337] unable to build WebRTC for iOS Simulator : [Attachment 373154] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 199337: unable to build WebRTC for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=199337

Attachment 373154: Patch

https://bugs.webkit.org/attachment.cgi?id=373154&action=review




--- Comment #4 from Tim Horton <thorton at apple.com> ---
Comment on attachment 373154
  --> https://bugs.webkit.org/attachment.cgi?id=373154
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373154&action=review

> Source/ThirdParty/libwebrtc/libwebrtc.xcodeproj/project.pbxproj:3384
> +			script = "DYLD_ROOT_PATH=/ ${BUILT_PRODUCTS_DIR}/yasm
-fmacho64 -I ${SRCROOT}/Source/third_party/libvpx/source/config -I
${SRCROOT}/Source/third_party/libvpx/source/config/mac/x64 -I
${SRCROOT}/Source/third_party/libvpx/source/libvpx -o
${OBJECT_FILE_DIR_normal}/${CURRENT_ARCH}/${INPUT_FILE_BASE}.o
${INPUT_FILE_DIR}/${INPUT_FILE_BASE}.asm\n";

This is /such a hack/ and needs a comment and a bug tracking properly building
this for the host.