[webkit-reviews] review granted: [Bug 199222] [iOS Scrolling] Propagate scrolls to non-nested UIScrollViews : [Attachment 373104] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 28 09:15:08 PDT 2019

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 199222: [iOS Scrolling] Propagate scrolls to non-nested UIScrollViews

Attachment 373104: patch


--- Comment #5 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 373104
  --> https://bugs.webkit.org/attachment.cgi?id=373104

View in context: https://bugs.webkit.org/attachment.cgi?id=373104&action=review

> Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:141
> +		       if (auto* nonAncestorScrollingNode =

I'm having a hard time convincing myself that using
relatedScrollContainerIDs()[0] is correct. What does it mean to have more than
one? What is the order?

More information about the webkit-reviews mailing list