[webkit-reviews] review granted: [Bug 199317] Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733 : [Attachment 373108] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 28 08:22:34 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> has granted Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 199317: Remove traces of ENABLE_ICONDATABASE remaining after its removal in
219733
https://bugs.webkit.org/show_bug.cgi?id=199317

Attachment 373108: Patch

https://bugs.webkit.org/attachment.cgi?id=373108&action=review




--- Comment #3 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 373108
  --> https://bugs.webkit.org/attachment.cgi?id=373108
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=373108&action=review

> Source/WebKit/PlatformGTK.cmake:-529
> -	   "	    <file alias=\"images/urlIcon\">urlIcon.png</file>\n"

A quick grep suggests this is indeed stale. Goodbye!

> Source/WebKitLegacy/mac/WebView/WebView.mm:3325
> -#if ENABLE(ICONDATABASE)
> +#if PLATFORM(MAC)

OK, this matches the #if !TARGET_OS_IPHONE in WebFrameLoadDelegate.h. Good.


More information about the webkit-reviews mailing list