[webkit-reviews] review granted: [Bug 199301] Provide overrides for UIKit's suggested actions in UIContextMenuInteraction : [Attachment 373073] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 27 17:50:15 PDT 2019
Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 199301: Provide overrides for UIKit's suggested actions in
UIContextMenuInteraction
https://bugs.webkit.org/show_bug.cgi?id=199301
Attachment 373073: Patch
https://bugs.webkit.org/attachment.cgi?id=373073&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 373073
--> https://bugs.webkit.org/attachment.cgi?id=373073
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=373073&action=review
> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1191
> - at interface UIContextMenuConfiguration (NeededUntil51288435Fixed)
> + at interface UIContextMenuConfiguration (NeededUntil52295535Fixed)
oO that's quite the coincidence
> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1202
> +// FIXME: I don't think this Radar is correct. 51288435 is about something
else.
Seems like a silly comment :) Just fix it?
More information about the webkit-reviews
mailing list