[webkit-reviews] review granted: [Bug 199232] SubFrameSOAuthorizationSession should preserve the referrer header when falling back to web path : [Attachment 372962] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 199232: SubFrameSOAuthorizationSession should preserve the referrer header
when falling back to web path
https://bugs.webkit.org/show_bug.cgi?id=199232

Attachment 372962: Patch

https://bugs.webkit.org/attachment.cgi?id=372962&action=review




--- Comment #9 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 372962
  --> https://bugs.webkit.org/attachment.cgi?id=372962
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372962&action=review

>
Source/WebKit/UIProcess/Cocoa/SOAuthorization/SubFrameSOAuthorizationSession.mm
:71
> +		   frame->loadURL(navigationActionPtr->request().url(),
navigationActionPtr->request().httpReferrer());

I wonder whether other parameters might be needed in the future (cache policy,
user agent...).
Maybe we should pass navigationActionPtr->request() directly.