[webkit-reviews] review granted: [Bug 199252] Web Inspector: throw an error if console.count/console.countReset is called with an object that throws an error from toString : [Attachment 372987] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 26 18:53:51 PDT 2019
Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 199252: Web Inspector: throw an error if console.count/console.countReset
is called with an object that throws an error from toString
https://bugs.webkit.org/show_bug.cgi?id=199252
Attachment 372987: Patch
https://bugs.webkit.org/attachment.cgi?id=372987&action=review
--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 372987
--> https://bugs.webkit.org/attachment.cgi?id=372987
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372987&action=review
r=me
> Source/JavaScriptCore/ChangeLog:13
> + for `console.time`, `console.timeLog`, and `console.TimeEnd`. Limit
the call stack to only
Nit: "TimeEnd" => "timeEnd" (multiple times in multiple ChangeLogs)
> Source/WebCore/inspector/InspectorInstrumentation.cpp:880
> - if (InspectorTimelineAgent* timelineAgent =
instrumentingAgents.inspectorTimelineAgent())
> - timelineAgent->time(frame, title);
> - if (WebConsoleAgent* consoleAgent =
instrumentingAgents.webConsoleAgent())
> - consoleAgent->startTiming(title);
> + if (auto* timelineAgent = instrumentingAgents.inspectorTimelineAgent())
> + timelineAgent->time(frame, label);
> + if (auto* consoleAgent = instrumentingAgents.webConsoleAgent())
> + consoleAgent->startTiming(exec, label);
I find the complete types in this file more useful when you need to search for
them. But auto is fine.
> Source/WebInspectorUI/UserInterface/Models/NativeFunctionParameters.js:183
> + timeLog: "label = \"default\"",
Nice!
More information about the webkit-reviews
mailing list