[webkit-reviews] review granted: [Bug 199108] [cmake] Switch to built-in handling of C++ standard instead of hardcoding -std=c++17 : [Attachment 372938] Patch

[bugzilla-daemon at webkit.org]

Don Olmstead <don.olmstead at sony.com> has granted Konstantin Tokarev
<annulen at yandex.ru>'s request for review:
Bug 199108: [cmake] Switch to built-in handling of C++ standard instead of
hardcoding -std=c++17
https://bugs.webkit.org/show_bug.cgi?id=199108

Attachment 372938: Patch

https://bugs.webkit.org/attachment.cgi?id=372938&action=review




--- Comment #14 from Don Olmstead <don.olmstead at sony.com> ---
Comment on attachment 372938
  --> https://bugs.webkit.org/attachment.cgi?id=372938
Patch

r=me but you forgot to remove the following in OptionsMSVC.cmake

# Enable C++17
#
https://docs.microsoft.com/en-us/cpp/build/reference/std-specify-language-stand
ard-version
add_compile_options(/std:c++17)