[webkit-reviews] review granted: [Bug 199246] Expose UIAction identifiers for _WKElementActions : [Attachment 372971] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 17:31:36 PDT 2019


Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 199246: Expose UIAction identifiers for _WKElementActions
https://bugs.webkit.org/show_bug.cgi?id=199246

Attachment 372971: Patch

https://bugs.webkit.org/attachment.cgi?id=372971&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 372971
  --> https://bugs.webkit.org/attachment.cgi?id=372971
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372971&action=review

> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.h:65
> -+ (UIImage *)imageForElementActionType:(_WKElementActionType)actionType
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(WK_IOS_TBA));
> ++ (UIImage *)imageForElementActionType:(_WKElementActionType)actionType
WK_API_AVAILABLE(macos(WK_MAC_TBA), ios(13.0));

Why this change?

> Source/WebKit/UIProcess/API/Cocoa/_WKElementAction.mm:217
> +#if !defined(TARGET_OS_IOS) || TARGET_OS_IOS

Why not a PLATFORM macro? This is an implementation file.


More information about the webkit-reviews mailing list