[webkit-reviews] review requested: [Bug 199195] Perform less work when a pre-warmed WebProcess is suspended or resumed. : [Attachment 372853] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has asked  for review:
Bug 199195: Perform less work when a pre-warmed WebProcess is suspended or
resumed.
https://bugs.webkit.org/show_bug.cgi?id=199195

Attachment 372853: Patch

https://bugs.webkit.org/attachment.cgi?id=372853&action=review




--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 372853
  --> https://bugs.webkit.org/attachment.cgi?id=372853
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372853&action=review

> Source/WebKit/WebProcess/WebProcess.cpp:1476
> +	   return;

Seems like it should do something like this before returning:
if (shouldAcknowledgeWhenReadyToSuspend ==
ShouldAcknowledgeWhenReadyToSuspend::Yes) {
    RELEASE_LOG(ProcessSuspension, "%p - WebProcess::actualPrepareToSuspend()
Sending ProcessReadyToSuspend IPC message", this);
   
parentProcessConnection()->send(Messages::WebProcessProxy::ProcessReadyToSuspen
d(), 0);
}

> Source/WebKit/WebProcess/WebProcess.cpp:1536
> +    ASSERT(m_processType != ProcessType::PrewarmedWebContent);

I am not convinced this assert is correct. Why do you think it is?