[webkit-reviews] review granted: [Bug 199220] [ContentChangeObserver] Dispatch synthetic mouse event asynchronously in completePendingSyntheticClickForContentChangeObserver : [Attachment 372901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 25 21:07:59 PDT 2019


Simon Fraser (smfr) <simon.fraser at apple.com> has granted  review:
Bug 199220: [ContentChangeObserver] Dispatch synthetic mouse event
asynchronously in completePendingSyntheticClickForContentChangeObserver
https://bugs.webkit.org/show_bug.cgi?id=199220

Attachment 372901: Patch

https://bugs.webkit.org/attachment.cgi?id=372901&action=review




--- Comment #2 from Simon Fraser (smfr) <simon.fraser at apple.com> ---
Comment on attachment 372901
  --> https://bugs.webkit.org/attachment.cgi?id=372901
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372901&action=review

> Source/WebKit/ChangeLog:10
> +	   WebPage::completePendingSyntheticClickForContentChangeObserver
should not dispatch mouse events synchronously as through style updates
> +	   they could destroy the element that initiated this change.
WebPage::handleSyntheticClick() already implements this pattern. 

"as through style updates" is hard to parse. Break into two sentences?

> Source/WebKit/WebProcess/WebPage/ios/WebPageIOS.mm:720
>  

Should you check if the targetNode is still connected?


More information about the webkit-reviews mailing list