[webkit-reviews] review requested: [Bug 199202] Add didBecomePrototype() calls to global context prototypes : [Attachment 372860] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 25 14:07:05 PDT 2019
Mark Lam <mark.lam at apple.com> has asked for review:
Bug 199202: Add didBecomePrototype() calls to global context prototypes
https://bugs.webkit.org/show_bug.cgi?id=199202
Attachment 372860: Patch
https://bugs.webkit.org/attachment.cgi?id=372860&action=review
--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 372860
--> https://bugs.webkit.org/attachment.cgi?id=372860
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review
> Source/WebCore/bindings/js/JSWindowProxy.cpp:115
> + properties.didBecomePrototype();
> prototype->structure(vm)->setPrototypeWithoutTransition(vm,
&properties);
I thought we were going too make setPrototypeWithoutTransition() call
didBecomePrototype() on the passed in prototype object. Was there a change of
plans?
More information about the webkit-reviews
mailing list