[webkit-reviews] review requested: [Bug 199202] Add didBecomePrototype() calls to global context prototypes : [Attachment 372860] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 25 14:07:05 PDT 2019

Mark Lam <mark.lam at apple.com> has asked  for review:
Bug 199202: Add didBecomePrototype() calls to global context prototypes

Attachment 372860: Patch


--- Comment #6 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 372860
  --> https://bugs.webkit.org/attachment.cgi?id=372860

View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review

> Source/WebCore/bindings/js/JSWindowProxy.cpp:115
> +    properties.didBecomePrototype();
>      prototype->structure(vm)->setPrototypeWithoutTransition(vm,

I thought we were going too make setPrototypeWithoutTransition() call
didBecomePrototype() on the passed in prototype object.  Was there a change of

More information about the webkit-reviews mailing list