[webkit-reviews] review granted: [Bug 199202] Add didBecomePrototype() calls to global context prototypes : [Attachment 372860] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 25 14:03:56 PDT 2019


Saam Barati <sbarati at apple.com> has granted Keith Miller
<keith_miller at apple.com>'s request for review:
Bug 199202: Add didBecomePrototype() calls to global context prototypes
https://bugs.webkit.org/show_bug.cgi?id=199202

Attachment 372860: Patch

https://bugs.webkit.org/attachment.cgi?id=372860&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 372860
  --> https://bugs.webkit.org/attachment.cgi?id=372860
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372860&action=review

>> Source/WebCore/ChangeLog:9
>> +	    marked as such to JSC.
> 
> What crashes? I thought the assert got rolled out? And we were doing things
in another way?

Do you mean this will crash a future change? Can you be more specific here


More information about the webkit-reviews mailing list