[webkit-reviews] review granted: [Bug 199187] When Caps Lock is enabled on the Smart Keyboard, can't scroll with space or arrow keys : [Attachment 372826] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 199187: When Caps Lock is enabled on the Smart Keyboard, can't scroll with
space or arrow keys
https://bugs.webkit.org/show_bug.cgi?id=199187

Attachment 372826: Patch

https://bugs.webkit.org/attachment.cgi?id=372826&action=review




--- Comment #3 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 372826
  --> https://bugs.webkit.org/attachment.cgi?id=372826
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372826&action=review

> Source/WebKit/UIProcess/ios/WKKeyboardScrollingAnimator.mm:246
> +    auto relevantModifierFlags = WebEventFlagMaskOptionKey |
WebEventFlagMaskCommandKey | WebEventFlagMaskShiftKey;

Looks like WebEventFlag should be an OptionSet.