[webkit-reviews] review requested: [Bug 195834] Can't use $0, $1 etc when inspecting Google Docs pages because the content uses these for function names : [Attachment 372824] Patch

[bugzilla-daemon at webkit.org]

Devin Rousso <drousso at apple.com> has asked  for review:
Bug 195834: Can't use $0, $1 etc when inspecting Google Docs pages because the
content uses these for function names
https://bugs.webkit.org/show_bug.cgi?id=195834

Attachment 372824: Patch

https://bugs.webkit.org/attachment.cgi?id=372824&action=review




--- Comment #14 from Devin Rousso <drousso at apple.com> ---
Created attachment 372824

  --> https://bugs.webkit.org/attachment.cgi?id=372824&action=review

Patch

After talking offline with @JoePeck, we decided that a better course of action
is to have the setting be an alias instead, meaning that both the input value
and "$" work as a prefix.  This way, the existing functionality of "$" is
preserved while still providing an alternate way of referencing the values that
is less likely to collide with a value in the page.