[webkit-reviews] review granted: [Bug 198960] Introduce LinkLoadParameters : [Attachment 372346] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has granted Rob Buis
<rbuis at igalia.com>'s request for review:
Bug 198960: Introduce LinkLoadParameters
https://bugs.webkit.org/show_bug.cgi?id=198960

Attachment 372346: Patch

https://bugs.webkit.org/attachment.cgi?id=372346&action=review




--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 372346
  --> https://bugs.webkit.org/attachment.cgi?id=372346
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372346&action=review

> Source/WebCore/html/HTMLLinkElement.cpp:273
> +	   attributeWithoutSynchronization(imagesizesAttr) };

I would put the closing "};" on a new line. Not sure if check-webkit-style
likes it or not...

> Source/WebCore/loader/LinkLoader.cpp:218
> +    if (!params.relAttribute.isLinkPreconnect || !href.isValid() ||
!params.href.protocolIsInHTTPFamily() || !document.frame())

I see you are using href.isValid(), params.href.protocolIsInHTTPFamily() and
SecurityOrigin::create(href)

Is introducing this local href variable actually needed?