[webkit-reviews] review granted: [Bug 199173] Pages using Google's anti-flicker optimization may take ~5 seconds to do initial paint : [Attachment 372794] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 24 14:48:32 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 199173: Pages using Google's anti-flicker optimization may take ~5 seconds
to do initial paint
https://bugs.webkit.org/show_bug.cgi?id=199173

Attachment 372794: Patch

https://bugs.webkit.org/attachment.cgi?id=372794&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 372794
  --> https://bugs.webkit.org/attachment.cgi?id=372794
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372794&action=review

r=me

> Source/WebCore/contentextensions/ContentExtensionsBackend.cpp:240
> +	       if
(currentDocument->settings().googleAntiFlickerOptimizationQuirkEnabled() && url
== "https://www.google-analytics.com/analytics.js"_str) {

Should we also check site-specific quirks enabled here? Would be nice to enable
a developer to test a fix in this area with our quirk turned off.


More information about the webkit-reviews mailing list