[webkit-reviews] review denied: [Bug 198518] REGRESSION(r245586): static assertion failed: Match result and EncodedMatchResult should be the same size : [Attachment 372782] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 24 12:55:22 PDT 2019


Michael Catanzaro <mcatanzaro at igalia.com> has denied Eike Rathke
<erack at redhat.com>'s request for review:
Bug 198518: REGRESSION(r245586): static assertion failed: Match result and
EncodedMatchResult should be the same size
https://bugs.webkit.org/show_bug.cgi?id=198518

Attachment 372782: proposed patch

https://bugs.webkit.org/attachment.cgi?id=372782&action=review




--- Comment #9 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372782
  --> https://bugs.webkit.org/attachment.cgi?id=372782
proposed patch

Thanks again. BTW, the patch should have a ChangeLog entry when setting r?
which you can create with:

Tools/Scripts/prepare-ChangeLog -b 198518

(If it's just a WIP patch without a changelog, don't set r? yet.)


More information about the webkit-reviews mailing list