[webkit-reviews] review granted: [Bug 199133] [Async overflow scroll] Clipped composited layers inside overflow scroll jitter and get incorrectly clipped : [Attachment 372693] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 199133: [Async overflow scroll] Clipped composited layers inside overflow
scroll jitter and get incorrectly clipped
https://bugs.webkit.org/show_bug.cgi?id=199133

Attachment 372693: Patch

https://bugs.webkit.org/attachment.cgi?id=372693&action=review




--- Comment #3 from Antti Koivisto <koivisto at iki.fi> ---
Comment on attachment 372693
  --> https://bugs.webkit.org/attachment.cgi?id=372693
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372693&action=review

> Source/WebCore/ChangeLog:54
> +	   With this patch, ScrollingTreePositionedNode are purely for absolute
position inside non-containing-block
> +	   stacking context overflow scroll. LayoutConstraints is renamed to
AbsolutePositionConstraints accordingly.

You might also want to rename ScrollingTreePositionedNode to something more
specific (AbsolutePositionedNode?).

>
LayoutTests/compositing/scrolling/async-overflow-scrolling/clipped-layer-in-ove
rflow-clipped-by-scroll.html:50
> +		   document.getElementById('layers').innerText =
window.internals.layerTreeAsText(document,
internals.LAYER_TREE_INCLUDES_CLIPPING);

It would be good to also have some dynamic reftests showing element moving like
they should, not just tree dumps.