[webkit-reviews] review granted: [Bug 199125] REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on last property no longer focuses on selector on next rule : [Attachment 372668] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jun 22 10:56:44 PDT 2019


Matt Baker <mattbaker at apple.com> has granted Nikita Vasilyev
<nvasilyev at apple.com>'s request for review:
Bug 199125: REGRESSION(r241980): Web Inspector: Styles: Pressing Tab/Enter on
last property no longer focuses on selector on next rule
https://bugs.webkit.org/show_bug.cgi?id=199125

Attachment 372668: Patch

https://bugs.webkit.org/attachment.cgi?id=372668&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 372668
  --> https://bugs.webkit.org/attachment.cgi?id=372668
Patch

r=me, works as advertised!

I noticed we show the green "change added" treatment for newly added blank
properties. Maybe we should delay doing this until some property name text is
actually entered.


More information about the webkit-reviews mailing list