[webkit-reviews] review granted: [Bug 199114] WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy : [Attachment 372649] Patch

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 199114: WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
https://bugs.webkit.org/show_bug.cgi?id=199114

Attachment 372649: Patch

https://bugs.webkit.org/attachment.cgi?id=372649&action=review




--- Comment #8 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 372649
  --> https://bugs.webkit.org/attachment.cgi?id=372649
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372649&action=review

> Source/WebKit/Shared/LoadParameters.h:82
> +template<> struct EnumTraits<WebCore::ShouldOpenExternalURLsPolicy> {

This might be best put next to ShouldOpenExternalURLsPolicy definition.

>
Source/WebKit/UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm
:59
> +    auto* navigationActionPtr = navigationAction();

maybe: auto* navigationAction = this->navigationAction();

>
Source/WebKit/UIProcess/Cocoa/SOAuthorization/RedirectSOAuthorizationSession.mm
:85
>      if (response.httpStatusCode() == 200) {

Do we need that if given the above if checks?

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:1577
> +    ShouldOpenExternalURLsPolicy externalURLsPolicy =
static_cast<ShouldOpenExternalURLsPolicy>(loadParameters.shouldOpenExternalURLs
Policy);

No need for static_cast.
We could even remove externalURLsPolicy.