[webkit-reviews] review granted: [Bug 198805] openDatabase should return an empty object when WebSQL is disabled : [Attachment 372641] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 13:14:17 PDT 2019

Geoffrey Garen <ggaren at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 198805: openDatabase should return an empty object when WebSQL is disabled

Attachment 372641: Patch


--- Comment #7 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 372641
  --> https://bugs.webkit.org/attachment.cgi?id=372641

View in context: https://bugs.webkit.org/attachment.cgi?id=372641&action=review

r=me with two changes

> Source/JavaScriptCore/runtime/JSFunction.h:83
> +    JS_EXPORT_PRIVATE static JSFunction* createUndefinedFunction(VM&,
JSGlobalObject*, int length, const String& name, NativeFunction, Intrinsic =
NoIntrinsic, NativeFunction nativeConstructor = callHostFunctionAsConstructor,
const DOMJIT::Signature* = nullptr);

Let's call this createFunctionThatMasqueradesAsUndefined. This is a weird
enough behavior that it deserves a detailed name.

> Source/WebCore/bindings/js/JSDOMWindowCustom.cpp:617
> +    if (!name)
> +	   name = vm.propertyNames->anonymous.impl();

I don't think you need this null check. Is it needed for something? I'd suggest
removing it.

More information about the webkit-reviews mailing list