[webkit-reviews] review denied: [Bug 199085] Implement a new SPI to inform clients about AppSSO : [Attachment 372598] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 10:45:03 PDT 2019


Brent Fulgham <bfulgham at webkit.org> has denied Jiewen Tan
<jiewen_tan at apple.com>'s request for review:
Bug 199085: Implement a new SPI to inform clients about AppSSO
https://bugs.webkit.org/show_bug.cgi?id=199085

Attachment 372598: Patch

https://bugs.webkit.org/attachment.cgi?id=372598&action=review




--- Comment #4 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 372598
  --> https://bugs.webkit.org/attachment.cgi?id=372598
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372598&action=review

This seems reasonable, but we need a WK API review (ggaren?), and please fix
the build issues I highlighted. r- to fix the build.

> Source/WebKit/UIProcess/API/APINavigationClient.h:35
> +#include "SOAuthorizationLoadPolicy.h"

This needs to be protected with HAVE(APP_SSO).

> Source/WebKit/UIProcess/WebPageProxy.h:44
> +#include "SOAuthorizationLoadPolicy.h"

This needs to be protected by HAVE(APP_SSO)


More information about the webkit-reviews mailing list