[webkit-reviews] review granted: [Bug 199097] Make sure to check for file descriptor value before using FD_CLR : [Attachment 372609] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 09:43:18 PDT 2019


Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 199097: Make sure to check for file descriptor value before using FD_CLR
https://bugs.webkit.org/show_bug.cgi?id=199097

Attachment 372609: Patch

https://bugs.webkit.org/attachment.cgi?id=372609&action=review




--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 372609
  --> https://bugs.webkit.org/attachment.cgi?id=372609
Patch

Is it worth adding a GetDescriptor() check in ProcessEvents, or is getsockopt()
with an invalid file descriptor harmless?


More information about the webkit-reviews mailing list