[webkit-reviews] review granted: [Bug 199080] WebKit context menu highlights include extra padding : [Attachment 372584] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 20 14:47:59 PDT 2019
Dean Jackson <dino at apple.com> has granted Tim Horton <thorton at apple.com>'s
request for review:
Bug 199080: WebKit context menu highlights include extra padding
https://bugs.webkit.org/show_bug.cgi?id=199080
Attachment 372584: Patch
https://bugs.webkit.org/attachment.cgi?id=372584&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 372584
--> https://bugs.webkit.org/attachment.cgi?id=372584
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372584&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2069
> + request.linkIndicatorShouldHaveLegacyMargins =
!self._shouldUseContextMenus;
It doesn't matter but _shouldUseContextMenus is a method. It probably should be
actually declared as a property as well.
Is this code within HAVE(LINK_PREVIEW)? I know the others are.
More information about the webkit-reviews
mailing list