[webkit-reviews] review granted: [Bug 199063] WebURLSchemeHandlerProxy::loadSynchronously crash with sync request : [Attachment 372582] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 14:37:17 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 199063: WebURLSchemeHandlerProxy::loadSynchronously crash with sync request
https://bugs.webkit.org/show_bug.cgi?id=199063

Attachment 372582: Patch

https://bugs.webkit.org/attachment.cgi?id=372582&action=review




--- Comment #4 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 372582
  --> https://bugs.webkit.org/attachment.cgi?id=372582
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372582&action=review

r=me

> Source/WebKit/WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp:67
> +    data.shrink(0);

Why shrink here?


More information about the webkit-reviews mailing list