[webkit-reviews] review granted: [Bug 199043] Add unit test for UIContextMenuConfiguration API : [Attachment 372565] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 199043: Add unit test for UIContextMenuConfiguration API
https://bugs.webkit.org/show_bug.cgi?id=199043

Attachment 372565: Patch

https://bugs.webkit.org/attachment.cgi?id=372565&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 372565
  --> https://bugs.webkit.org/attachment.cgi?id=372565
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372565&action=review

> Source/WebKit/Platform/spi/ios/UIKitSPI.h:1196
> + at property (nonatomic, weak) id<_UIClickInteractionDriverDelegate> delegate;

Nit - I think we usually put a space between id and < for ObjC protocols.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfiguration.mm:799
> +- (id<_UIClickInteractionDriving>)_clickInteractionDriverForTesting

Nit - space here too.

> Source/WebKit/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:89
> + at property (nonatomic, setter=_setClickInteractionDriverForTesting:)
id<_UIClickInteractionDriving> _clickInteractionDriverForTesting
WK_API_AVAILABLE(ios(WK_IOS_TBA));

Nit - space here too.

> Tools/TestWebKitAPI/ios/UIKitSPI.h:207
> +    

Nit - extra newline