[webkit-reviews] review granted: [Bug 199052] Web Inspector: Edit -> Tag doesn't do anything for html, head, and body elements : [Attachment 372566] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 199052: Web Inspector: Edit -> Tag doesn't do anything for html, head, and
body elements
https://bugs.webkit.org/show_bug.cgi?id=199052

Attachment 372566: Patch

https://bugs.webkit.org/attachment.cgi?id=372566&action=review




--- Comment #3 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 372566
  --> https://bugs.webkit.org/attachment.cgi?id=372566
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372566&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:801
> +	       if
(!DOMTreeElement.EditTagBlacklist.has(this.representedObject.nodeNameInCorrectC
ase())) {

Nit: I'd move `let tagNameNode = event.target.closest(".html-tag-name");` (line
746 above) to here to where it is used.