[webkit-reviews] review granted: [Bug 198999] [Pointer Events] Respect pointer capture when dispatching mouse boundary events and updating :hover : [Attachment 372551] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 11:39:15 PDT 2019


Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 198999: [Pointer Events] Respect pointer capture when dispatching mouse
boundary events and updating :hover
https://bugs.webkit.org/show_bug.cgi?id=198999

Attachment 372551: Patch

https://bugs.webkit.org/attachment.cgi?id=372551&action=review




--- Comment #9 from Dean Jackson <dino at apple.com> ---
Comment on attachment 372551
  --> https://bugs.webkit.org/attachment.cgi?id=372551
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372551&action=review

> Source/WebCore/page/EventHandler.h:417
> +    bool dispatchMouseEvent(const AtomString& eventType, Node* target, bool
cancelable, int clickCount, const PlatformMouseEvent&, bool setUnder, const
HitTestRequest&, MouseEventWithHitTestResults&);

I think you should give this a slightly different name to make it more clear.
Or maybe call the other one base? Or use default parameter values?


More information about the webkit-reviews mailing list