[webkit-reviews] review denied: [Bug 199047] Web Inspector: current call frame indicator not visible in dark mode : [Attachment 372567] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 20 11:22:06 PDT 2019
Devin Rousso <drousso at apple.com> has denied Matt Baker <mattbaker at apple.com>'s
request for review:
Bug 199047: Web Inspector: current call frame indicator not visible in dark
mode
https://bugs.webkit.org/show_bug.cgi?id=199047
Attachment 372567: Patch
https://bugs.webkit.org/attachment.cgi?id=372567&action=review
--- Comment #5 from Devin Rousso <drousso at apple.com> ---
Comment on attachment 372567
--> https://bugs.webkit.org/attachment.cgi?id=372567
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372567&action=review
r-
> Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css:58
> + display: none;
This cause the current call frame icon to disappear when changing call frames
across an async boundary.
# STEPS TO REPRODUCE:
1. inspect <https://webkit.org>
2. set a breakpoint on the first line inside `enableScrollableTables`
3. refresh the page
=> debugger should pause on the breakpoint set in step 2
4. change call frames to the one before `--- addEvent Listener ---` (should be
`Global Code`)
=> the |> on the `enableScrollableTables` call frame disappears
> Source/WebInspectorUI/UserInterface/Views/CallFrameTreeElement.css:107
> + fill: var(--selected-foreground-color);
I think this is too bright, especially when compared to the "selected but not
focused" background color.
We should create a version of `.tree-outline:focus .item.call-frame.selected
.status > .status-image` inside a `@media (prefers-color-scheme: dark)`.
More information about the webkit-reviews
mailing list