[webkit-reviews] review granted: [Bug 199033] Web Inspector: Debugger: setting a breakpoint on a non-JavaScript line should immediately show as unresolved : [Attachment 372497] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 199033: Web Inspector: Debugger: setting a breakpoint on a non-JavaScript
line should immediately show as unresolved
https://bugs.webkit.org/show_bug.cgi?id=199033

Attachment 372497: Patch

https://bugs.webkit.org/attachment.cgi?id=372497&action=review




--- Comment #2 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 372497
  --> https://bugs.webkit.org/attachment.cgi?id=372497
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372497&action=review

r=me, nice change.

> Source/WebInspectorUI/ChangeLog:12
> +	   by the time that `shouldSpeculativelyResolve` would've taken effect,
so it's unnecessary.

Any idea why it existed in the first place?

> Source/WebInspectorUI/ChangeLog:14
> +	   This only affects resolving breakpoints set via the gutter of a
`SourceCodeTextEditor`.

Maybe "This parameter was only used when setting a breakpoint via...". I had to
check the code to clarify.

> Source/WebInspectorUI/UserInterface/Controllers/DebuggerManager.js:933
> +    _setBreakpoint(breakpoint, specificTarget)

Interesting. It looks like a breakpoint only begins its life in the resolved
state when restoring breakpoints in DebuggerManager.prototype.initializeTarget
(specificTarget will be non-null).