[webkit-reviews] review requested: [Bug 197358] [GStreamer] Volume level sometimes changes inappropriately : [Attachment 372555] Patch

[bugzilla-daemon at webkit.org]

Charlie Turner <cturner at igalia.com> has asked  for review:
Bug 197358: [GStreamer] Volume level sometimes changes inappropriately
https://bugs.webkit.org/show_bug.cgi?id=197358

Attachment 372555: Patch

https://bugs.webkit.org/attachment.cgi?id=372555&action=review




--- Comment #19 from Charlie Turner <cturner at igalia.com> ---
Created attachment 372555

  --> https://bugs.webkit.org/attachment.cgi?id=372555&action=review

Patch

Do not remove the volume initialization code, for sites that do not set an
initial volume, this code at least preserves the last set volume across page
reloads at the cost of complexity. Note this is not the case for pretty much
every video streaming site in the wild, since they all set initial volumes
explicitly. It is also not a requirement of compliant user-agents, but may be
removed in the future with a larger refactoring in the pipeline.