[webkit-reviews] review granted: [Bug 196094] [GTK][WPE] Implement a basic DNS cache : [Attachment 372453] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 07:39:42 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 196094: [GTK][WPE] Implement a basic DNS cache

Attachment 372453: Patch


--- Comment #11 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372453
  --> https://bugs.webkit.org/attachment.cgi?id=372453

View in context: https://bugs.webkit.org/attachment.cgi?id=372453&action=review

> Source/WebKit/NetworkProcess/glib/WebKitCachedResolver.cpp:38
> +typedef struct {
> +    GRefPtr<GResolver> wrappedResolver;
> +    DNSCache cache;
> +} WebKitCachedResolverPrivate;

OK you're right, I suppose WebKitCachedResolver is threadsafe because both its
data members are.

I recommend adding a comment here to warn about this, otherwise it would be
really really easy to mess this up in the future by adding a non-threadsafe
member here without a lock.

More information about the webkit-reviews mailing list