[webkit-reviews] review granted: [Bug 199053] [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized : [Attachment 372514] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 19 20:16:38 PDT 2019


Saam Barati <sbarati at apple.com> has granted Yusuke Suzuki <ysuzuki at apple.com>'s
request for review:
Bug 199053: [bmalloc] IsoHeap's initialization is racy with
IsoHeap::isInitialized
https://bugs.webkit.org/show_bug.cgi?id=199053

Attachment 372514: Patch

https://bugs.webkit.org/attachment.cgi?id=372514&action=review




--- Comment #3 from Saam Barati <sbarati at apple.com> ---
Comment on attachment 372514
  --> https://bugs.webkit.org/attachment.cgi?id=372514
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372514&action=review

Nice!!! r=me

> Source/bmalloc/bmalloc/IsoHeapInlines.h:86
> +    auto* heap = new IsoHeapImpl<Config>();
> +    setAllocatorOffset(heap->allocatorOffset());
> +    setDeallocatorOffset(heap->deallocatorOffset());
> +    auto* atomic =
reinterpret_cast<std::atomic<IsoHeapImpl<Config>*>*>(&m_impl);
> +    atomic->store(heap, std::memory_order_release);

Can you comment on this ordering being important?


More information about the webkit-reviews mailing list