[webkit-reviews] review granted: [Bug 199045] No menu pop-up when long pressing on a link in Firefox app : [Attachment 372505] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 19 17:59:55 PDT 2019
Tim Horton <thorton at apple.com> has granted Dean Jackson <dino at apple.com>'s
request for review:
Bug 199045: No menu pop-up when long pressing on a link in Firefox app
https://bugs.webkit.org/show_bug.cgi?id=199045
Attachment 372505: Patch
https://bugs.webkit.org/attachment.cgi?id=372505&action=review
--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 372505
--> https://bugs.webkit.org/attachment.cgi?id=372505
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372505&action=review
> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:7450
> + _previewGestureRecognizer =
_previewItemController.get().presentationGestureRecognizer;
IMO [ ] instead of .get() but could go either way
More information about the webkit-reviews
mailing list