[webkit-reviews] review granted: [Bug 198981] DownloadMonitor::measuredThroughputRate should approach zero with no throughput : [Attachment 372405] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 19 10:31:23 PDT 2019


Geoffrey Garen <ggaren at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 198981: DownloadMonitor::measuredThroughputRate should approach zero with
no throughput
https://bugs.webkit.org/show_bug.cgi?id=198981

Attachment 372405: Patch

https://bugs.webkit.org/attachment.cgi?id=372405&action=review




--- Comment #3 from Geoffrey Garen <ggaren at apple.com> ---
Comment on attachment 372405
  --> https://bugs.webkit.org/attachment.cgi?id=372405
Patch

r=me

I wonder if our API test can cover this. You'd need to add a way to explicitly
set the timer duration for testing, so the test didn't take five minutes. A
little gross, but seems doable.


More information about the webkit-reviews mailing list