[webkit-reviews] review granted: [Bug 198990] Tidy up the remaining bits of the AtomicString to AtomString rename : [Attachment 372427] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 198990: Tidy up the remaining bits of the AtomicString to AtomString rename
https://bugs.webkit.org/show_bug.cgi?id=198990

Attachment 372427: Patch

https://bugs.webkit.org/attachment.cgi?id=372427&action=review




--- Comment #4 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372427
  --> https://bugs.webkit.org/attachment.cgi?id=372427
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372427&action=review

> Source/WTF/wtf/text/AtomString.h:-180
> -using AtomicString = AtomString;

Ah you got rid of it already! That was quick.

> Source/WTF/wtf/text/AtomStringImpl.h:52
>	   if (!string)
> -	       return static_cast<AtomStringImpl*>(string);
> +	       return nullptr;

Good cleanup.

> Source/WTF/wtf/text/StringImpl.h:211
>      enum StringKind {
>	   StringNormal = 0u, // non-symbol, non-atomic
> -	   StringAtomic = s_hashFlagStringKindIsAtomic, // non-symbol, atomic
> +	   StringAtomic = s_hashFlagStringKindIsAtom, // non-symbol, atomic
>	   StringSymbol = s_hashFlagStringKindIsSymbol, // symbol, non-atomic
>      };

Missed some spots here!