[webkit-reviews] review denied: [Bug 199000] [GTK] Fix compilation errors for the GTK2 plugin process : [Attachment 372462] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 19 08:53:17 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has denied Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 199000: [GTK] Fix compilation errors for the GTK2 plugin process

Attachment 372462: Patch


--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372462
  --> https://bugs.webkit.org/attachment.cgi?id=372462

This is a bit weird though, because we are about to delete the plugin process
so no more GTK 2, and our minimum GTK version is already 3.6. So it'd be nice
to not remove the GTK_API_VERSION_2 guards since that makes it obvious that the
code is there to support the plugin process.

I think it's important to investigate what's actually gone wrong here. Clearly
something else is up, because #ifndef GTK_API_VERSION_2 and #if
GTK_CHECK_VERSION(3, 2, 0) should be equivalent when we know GTK version is
either 2 or 3 >= 3.6.

More information about the webkit-reviews mailing list