[webkit-reviews] review granted: [Bug 198984] Relocate some test tools in non-mac builds : [Attachment 372408] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 18 17:57:19 PDT 2019

Andy Estes <aestes at apple.com> has granted Keith Rollin <krollin at apple.com>'s
request for review:
Bug 198984: Relocate some test tools in non-mac builds

Attachment 372408: Patch


--- Comment #5 from Andy Estes <aestes at apple.com> ---
Comment on attachment 372408
  --> https://bugs.webkit.org/attachment.cgi?id=372408

View in context: https://bugs.webkit.org/attachment.cgi?id=372408&action=review

> Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:-1389

It'd be nice to also move INSTALL_PATH from the pbxproj to an .xcconfig file.
WEBKIT_FRAMEWORK_RESOURCES_PATH's effect is a little mysterious otherwise (at
least it was to me while reviewing).

More information about the webkit-reviews mailing list