[webkit-reviews] review granted: [Bug 198978] [WHLSL] Create a shading language test harness : [Attachment 372399] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jun 18 17:30:26 PDT 2019

Myles C. Maxfield <mmaxfield at apple.com> has granted Justin Fan
<justin_fan at apple.com>'s request for review:
Bug 198978: [WHLSL] Create a shading language test harness

Attachment 372399: Patch


--- Comment #4 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 372399
  --> https://bugs.webkit.org/attachment.cgi?id=372399

View in context: https://bugs.webkit.org/attachment.cgi?id=372399&action=review

I don’t see any WHLSL yet. What would that look like using this harness?

> LayoutTests/webgpu/whlsl-harness-test.html:27
> +let tests = {};

Can the harness be used in many different tests? I think we will want many
files rather than dumping all the tests in a single file.

More information about the webkit-reviews mailing list