[webkit-reviews] review granted: [Bug 198876] [WHLSL] Support matrices : [Attachment 372409] patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Saam Barati <sbarati at apple.com>'s
request for review:
Bug 198876: [WHLSL] Support matrices
https://bugs.webkit.org/show_bug.cgi?id=198876

Attachment 372409: patch

https://bugs.webkit.org/attachment.cgi?id=372409&action=review




--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 372409
  --> https://bugs.webkit.org/attachment.cgi?id=372409
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372409&action=review

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:629
> +native float3 operator[](float2x3, uint);
> +native float2x3 operator[]=(float2x3, uint, float3);

Why is this just for these two types?

> Source/WebCore/Modules/webgpu/WHLSL/WHLSLStandardLibrary.txt:697
> +    float2x3 result;
> +    result[0][0] = a[0][0] - b;
> +    result[0][1] = a[0][1] - b;
> +    result[0][2] = a[0][2] - b;
> +    result[1][0] = a[1][0] - b;
> +    result[1][1] = a[1][1] - b;
> +    result[1][2] = a[1][2] - b;
> +    return result;

Why not just return operator+(a, -b)?