[webkit-reviews] review granted: [Bug 198974] Update WebKit API to separately retrieve actions and use context menus : [Attachment 372371] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 198974: Update WebKit API to separately retrieve actions and use context
menus
https://bugs.webkit.org/show_bug.cgi?id=198974

Attachment 372371: Patch

https://bugs.webkit.org/attachment.cgi?id=372371&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 372371
  --> https://bugs.webkit.org/attachment.cgi?id=372371
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372371&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKUIDelegate.h:170
> +- (void)webView:(WKWebView *)webView
contextMenuConfigurationForElement:(WKContextMenuElementInfo *)elementInfo
completionHandler:(void (^)(UIContextMenuConfiguration *
_Nullable))completionHandler WK_API_AVAILABLE(ios(WK_IOS_TBA));

I think you want to name the block parameters so that Xcode pops a name in for
you? We do in other places.

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.h:489
> +- (void)ensurePositionInformationIsUpToDate:(const
WebKit::InteractionInformationRequest&)request
completionHandler:(CompletionHandler<void(BOOL)>&&)completionHandler;

I don't think we need an additional way to get async position information
updates; see above.