[webkit-reviews] review granted: [Bug 198922] REGRESSION (r240757): Cannot dismiss the keyboard on http://apple.com/apple-tv-plus : [Attachment 372374] Patch

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 198922: REGRESSION (r240757): Cannot dismiss the keyboard on
http://apple.com/apple-tv-plus
https://bugs.webkit.org/show_bug.cgi?id=198922

Attachment 372374: Patch

https://bugs.webkit.org/attachment.cgi?id=372374&action=review




--- Comment #8 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 372374
  --> https://bugs.webkit.org/attachment.cgi?id=372374
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372374&action=review

> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:1228
> +	       [self _elementDidBlur];

I think the name “elementDidBlur” is a bit misleading now. When invoked from
this call site, it’s more like “elementWillBlur”. But when invoked via IPC from
the web process, it’s still “elementDidBlur”.

Maybe we could use a more generic name. handleElementBlur? Or perhaps
cleanUpAfterElementBlur?