[webkit-reviews] review granted: [Bug 198971] Web Inspector: parseQueryParameters fails to successfully parse query parameter values that contain "=" : [Attachment 372354] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 198971: Web Inspector: parseQueryParameters fails to successfully parse
query parameter values that contain "="
https://bugs.webkit.org/show_bug.cgi?id=198971

Attachment 372354: Patch

https://bugs.webkit.org/attachment.cgi?id=372354&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 372354
  --> https://bugs.webkit.org/attachment.cgi?id=372354
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372354&action=review

> LayoutTests/inspector/unit-tests/url-utilities.html:413
> +	       test("a&b=1&c==2=&d&e=3&f==4=", {a: "", b: "1", c: "=2=", d: "",
e: "3", f: "=4="});

Would be nice to have one that has encoded values / keys, etc.

    test("a=foo%20bar&b=123%3A456, {a: "foo bar", b: "123:456"})