[webkit-reviews] review granted: [Bug 198970] Change log channel name from ResourceLoadStatisticsDebug to ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED : [Attachment 372351] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jun 18 11:14:12 PDT 2019
Brent Fulgham <bfulgham at webkit.org> has granted John Wilander
<wilander at apple.com>'s request for review:
Bug 198970: Change log channel name from ResourceLoadStatisticsDebug to
ITPDebug and remove unnecessary #if !RELEASE_LOG_DISABLED
https://bugs.webkit.org/show_bug.cgi?id=198970
Attachment 372351: Patch
https://bugs.webkit.org/attachment.cgi?id=372351&action=review
--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 372351
--> https://bugs.webkit.org/attachment.cgi?id=372351
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=372351&action=review
Looks good, aside from the unused function. r=me if you fix that.
> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsStore.cpp:-89
> -#endif
I think the build will fail (due to unused function warnings) if you remove
these #if/defs.
More information about the webkit-reviews
mailing list