[webkit-reviews] review granted: [Bug 198925] [iOS] Pressing key while holding Command should not insert character : [Attachment 372259] Patch and test

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has granted Daniel Bates
<dbates at webkit.org>'s request for review:
Bug 198925: [iOS] Pressing key while holding Command should not insert
character
https://bugs.webkit.org/show_bug.cgi?id=198925

Attachment 372259: Patch and test

https://bugs.webkit.org/attachment.cgi?id=372259&action=review




--- Comment #3 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 372259
  --> https://bugs.webkit.org/attachment.cgi?id=372259
Patch and test

View in context: https://bugs.webkit.org/attachment.cgi?id=372259&action=review

Looks reasonable. r=me.

> Source/WebKit/ChangeLog:11
> +	   time of writing) should not insert v. This matches iOS and Mac
platform conventions.

Yes!