[webkit-reviews] review granted: [Bug 198916] [GStreamer] Identify elements with monotonically increasing counters : [Attachment 372245] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 17 23:59:35 PDT 2019


Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 198916: [GStreamer] Identify elements with monotonically increasing
counters
https://bugs.webkit.org/show_bug.cgi?id=198916

Attachment 372245: Patch

https://bugs.webkit.org/attachment.cgi?id=372245&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 372245
  --> https://bugs.webkit.org/attachment.cgi?id=372245
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=372245&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:2389
> +    static Atomic<uint32_t> pipelineId = 0;

I guess you don't need to initialize this because it is the only place were you
do it.


More information about the webkit-reviews mailing list