[webkit-reviews] review denied: [Bug 198937] Web Inspector: Elements: add/edit/copy/delete menus should have a "..." in the label : [Attachment 372292] Patch

[bugzilla-daemon at webkit.org]

Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 198937: Web Inspector: Elements: add/edit/copy/delete menus should have a
"..." in the label
https://bugs.webkit.org/show_bug.cgi?id=198937

Attachment 372292: Patch

https://bugs.webkit.org/attachment.cgi?id=372292&action=review




--- Comment #4 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 372292
  --> https://bugs.webkit.org/attachment.cgi?id=372292
Patch

This goes against Apple's HI Guidelines (which I clearly didn't check before
adding the "Break on..." context menu item). Here is the relevant
documentation:

[Copied from
https://developer.apple.com/design/human-interface-guidelines/macos/menus/menu-
anatomy/]

Menu Item Titles
A menu item title describes an action or attribute.

Use an ellipsis whenever choosing a menu item requires additional input from
the user. The ellipsis character (…) means a dialog or separate window will
open and prompt the user for additional information or to make a choice.