[webkit-reviews] review requested: [Bug 198925] [iOS] Pressing key while holding Command should not insert character : [Attachment 372259] Patch and test
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jun 17 11:30:30 PDT 2019
Daniel Bates <dbates at webkit.org> has asked for review:
Bug 198925: [iOS] Pressing key while holding Command should not insert
character
https://bugs.webkit.org/show_bug.cgi?id=198925
Attachment 372259: Patch and test
https://bugs.webkit.org/attachment.cgi?id=372259&action=review
--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 372259
--> https://bugs.webkit.org/attachment.cgi?id=372259&action=review
Patch and test
If I have a moment, I will look to write a more comprehensive test. Maybe I
could modify the fast/events/ios/key-event-comprehensive tests. I didn't want
to now since these tests already run longish and I did not want to tempt fate
with a modification that could make them run even longer ... and timeout. Maybe
I could duplicate these tests as an alternative.
More information about the webkit-reviews
mailing list