[webkit-reviews] review granted: [Bug 198797] Ensure ITP state is relayed to Network Process on restart : [Attachment 372086] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 17 09:41:41 PDT 2019


youenn fablet <youennf at gmail.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 198797: Ensure ITP state is relayed to Network Process on restart
https://bugs.webkit.org/show_bug.cgi?id=198797

Attachment 372086: Patch

https://bugs.webkit.org/attachment.cgi?id=372086&action=review




--- Comment #17 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 372086
  --> https://bugs.webkit.org/attachment.cgi?id=372086
Patch

OK, let's roll this in.
Let's also handle itp enabling per session as a follow-up.

View in context: https://bugs.webkit.org/attachment.cgi?id=372086&action=review

> Source/WebKit/UIProcess/WebProcessPool.cpp:585
> +    bool enableResourceLoadStatistics = m_itpIsEnabled;

Since it only applies to the default session, I would rename it to something
like m_itpIsEnabledForDefaultSession or maybe just
m_iptEnabledForDefaultSessions


More information about the webkit-reviews mailing list