[webkit-reviews] review granted: [Bug 195276] Rename AtomicString to AtomString : [Attachment 372205] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jun 16 17:00:04 PDT 2019

Michael Catanzaro <mcatanzaro at igalia.com> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 195276: Rename AtomicString to AtomString

Attachment 372205: Patch


--- Comment #12 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 372205
  --> https://bugs.webkit.org/attachment.cgi?id=372205

View in context: https://bugs.webkit.org/attachment.cgi?id=372205&action=review

Thanks Darin! I certainly haven't looked at the whole diff, but it passes my
sanity check.

I suspect the Bugzilla review tool just isn't smart enough to notice renames?
Renames generally appear as renames on trac.

> Source/WTF/wtf/text/AtomString.h:180
> +using AtomicString = AtomString;

This deserves a FIXME to remove it when Apple is able to do that, right?

More information about the webkit-reviews mailing list